Four-dimension review (correctness/security/reliability/maintainability) of today's console/bus/login/dashboard/image work found no Critical/High; the HTTP parser, login gate (un-bypassable), bus semantics and the HMAC/PBKDF2/SHA-256 math were verified correct. The Medium findings are fixed here. Security: - Token-gate /api/files and /api/file (were session-only despite the docs/Security page claiming token-gated - arbitrary root-readable file exfiltration). - Neutralize settings-redirect header-splitting: __section/__tab are constrained to safe slugs before going into the Location header (CRLF no longer injects). - One token source (auth::rand_hex): fail loud + non-constant fallback instead of the published "dev-csrf-token" / second-granular wsid when /dev/urandom is unreadable. - Constant-time UI-token compare (auth::ct_eq); write auth.json 0600, dir 0700. - Cap concurrent connections (64, 503 beyond) + 10s head-read deadline, bounding the thread-per-connection flood on the open :80. Reliability/correctness: - Settings persistence now propagates its write error (was swallowed and reported as success with a misleading comment) and writes atomically (temp+rename); deck save atomic too. Auth::login returns None if the session insert failed. - TuningLoop::set_target resets the PID accumulator on a mode change (the old target's integral is in the old units) while keeping the operating point. - Editable-deck JS: monotonic new-block ids (no collision after remove+add), default source frequency (was power_w, not in the live map), symmetric drag-drop placement, re-render after save. Drivers "stopped" shows the bare reason, not JSON-quoted. Maintainability: - New `form` module consolidates the three divergent percent_decode/field copies (web/service/dashboard). Added a test asserting published state topics match the registry contract. Report in code-review-report.md (verdict, accepted-by-design posture incl. the no-TLS / factory-creds residual risk, and a deferred list: ui.rs dead code, deck assets extraction, target_label dedup). 206 lib tests + integration pass, clippy -D warnings clean, no emojis. Image rebuilt with the fixed binary. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BdKQBPjAXpCwmigUov5eQk
2.0 KiB
2.0 KiB
Code Review Memory
This file is maintained by the code-review-harness skill. It records
findings across review sessions so the skill can spot recurring issues
and apply more aggressive remediation when an issue persists.
The skill reads this file at the start of every review and updates it at the end with new findings.
How to use
- The "Recurring Issues" section is rebuilt automatically each run. Treat it as the high-signal list of things that keep coming back.
- The "Session Log" is append-only. Each row is one finding from one session. The log is the source of truth; the index is derived from it.
- If a finding has been fixed and you don't want it to count toward
recurrence anymore, add a
RESOLVED:row referencing the finding fingerprint.
Recurring Issues
(auto-generated — rebuilt at end of each session)
No recurring issues yet — every finding has been a one-off, or memory was just initialized.
Session Log
(append-only)
2026-11-10T21:41:18-06:00iter=1src/web.rs:320[Medium] files/file endpoints not token-gated (fixed) (fp:17293278c1c7)2026-11-10T21:41:18-06:00iter=1src/web.rs:389[Medium] settings redirect header-splitting via __section/__tab (fixed) (fp:073768bc5201)2026-11-10T21:41:18-06:00iter=1src/auth.rs:37[Medium] RNG fallback to constant csrf/guessable wsid (fixed) (fp:d45a2e52d1ba)2026-11-10T21:41:18-06:00iter=1src/dashboard.rs:199[Medium] settings write error swallowed, reported success (fixed) (fp:b6701ede5237)2026-11-10T21:41:18-06:00iter=1src/tuning.rs:180[Low] set_target kept PID integral across unit-mismatched modes (fixed) (fp:1b4915d2c7a6)2026-11-10T21:41:18-06:00iter=1src/console.rs:234[Medium] editable-deck new-block id collision (fixed) (fp:97ba434fdd3a)2026-11-10T21:41:18-06:00iter=1src/web.rs:81[Medium] unbounded thread-per-connection DoS (fixed: conn cap) (fp:0a2a1950ad0d)