adbd gate comment overstates fail-closed steps #50

Open
opened 2026-11-12 04:15:23 -07:00 by noah · 0 comments
Owner

The comment above ADBD_INPUTS in the 0015 Makefile hunk (luckfox-sdk-patches/board/patches/0015-adbd-no-tcp-listener.patch) says that every step below stops the rule when it fails.

That is not true. The rm -rf, the two tar -xf steps, pushd and cp -af have no failure check. The series, android-tools.patch.sh, build and copy steps do stop the rule, and README.md and tests/test-adbd-no-tcp.sh cover exactly those four.

Found during the independent verification of sp/adbd-tcp-off (head 3baa28a). The fix is a comment-only wording change; the rule's behaviour does not change.

Refs #45

The comment above ADBD_INPUTS in the 0015 Makefile hunk (luckfox-sdk-patches/board/patches/0015-adbd-no-tcp-listener.patch) says that every step below stops the rule when it fails. That is not true. The rm -rf, the two tar -xf steps, pushd and cp -af have no failure check. The series, android-tools.patch.sh, build and copy steps do stop the rule, and README.md and tests/test-adbd-no-tcp.sh cover exactly those four. Found during the independent verification of sp/adbd-tcp-off (head 3baa28a). The fix is a comment-only wording change; the rule's behaviour does not change. Refs #45
Sign in to join this conversation.
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: blueflare/bfe-core1106-sdk#50