The comment above ADBD_INPUTS in the 0015 Makefile hunk (luckfox-sdk-patches/board/patches/0015-adbd-no-tcp-listener.patch) says that every step below stops the rule when it fails.
That is not true. The rm -rf, the two tar -xf steps, pushd and cp -af have no failure check. The series, android-tools.patch.sh, build and copy steps do stop the rule, and README.md and tests/test-adbd-no-tcp.sh cover exactly those four.
Found during the independent verification of sp/adbd-tcp-off (head 3baa28a). The fix is a comment-only wording change; the rule's behaviour does not change.
The comment above ADBD_INPUTS in the 0015 Makefile hunk (luckfox-sdk-patches/board/patches/0015-adbd-no-tcp-listener.patch) says that every step below stops the rule when it fails.
That is not true. The rm -rf, the two tar -xf steps, pushd and cp -af have no failure check. The series, android-tools.patch.sh, build and copy steps do stop the rule, and README.md and tests/test-adbd-no-tcp.sh cover exactly those four.
Found during the independent verification of sp/adbd-tcp-off (head 3baa28a). The fix is a comment-only wording change; the rule's behaviour does not change.
Refs #45
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
The comment above ADBD_INPUTS in the 0015 Makefile hunk (luckfox-sdk-patches/board/patches/0015-adbd-no-tcp-listener.patch) says that every step below stops the rule when it fails.
That is not true. The rm -rf, the two tar -xf steps, pushd and cp -af have no failure check. The series, android-tools.patch.sh, build and copy steps do stop the rule, and README.md and tests/test-adbd-no-tcp.sh cover exactly those four.
Found during the independent verification of sp/adbd-tcp-off (head
3baa28a). The fix is a comment-only wording change; the rule's behaviour does not change.Refs #45