Files
BFE EngineeringandClaude Opus 5.5 b18ed3888b
ci / test (push) Successful in 16s
ci / prune-artifacts (pull_request) Skipped
ci / kernel-build (pull_request) Skipped
ci / bench (push) Successful in 11s
ci / patches-apply (push) Successful in 22s
ci / prune-artifacts (push) Skipped
ci / kernel-build (push) Skipped
ci / quality (push) Successful in 37s
ci / badges (push) Skipped
ci / qemu-tools (pull_request) Successful in 45s
ci / qemu-tools (push) Successful in 49s
ci / test (pull_request) Successful in 17s
ci / mcdc (pull_request) Successful in 19s
ci / bench (pull_request) Successful in 8s
ci / mcdc (push) Successful in 23s
ci / patches-apply (pull_request) Successful in 22s
ci / quality (pull_request) Successful in 34s
ci / badges (pull_request) Skipped
relays: refuse a WARDEN_GPIO_ROOT too long for PATH_MAX
Sysfs paths were built in fixed 80/96-byte stack buffers with unchecked
snprintf, so a root longer than about 70 bytes was truncated and both relays
silently read as unavailable.

Each operation now formats all of its paths up front into PATH_MAX buffers
and checks every snprintf return. A root whose longest path does not fit is
refused with a stderr line and the call reports unavailable, off or no-op;
nothing is ever truncated. The export argument comes from a constant table
instead of runtime formatting.

Regression tests: a 200-byte root through the fake io (full path reaches
the backend), the exact PATH_MAX boundary, one byte over (refused and logged
on available, get and set, io untouched), and a real scratch tree under a
root over 200 bytes. MC/DC stays at 100% (50/50 conditions).

Fixes #10

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01441BzdGcvQmXkiN2qDjfZg
2026-10-02 11:01:40 -06:00
..

Hardened Drivers

Per ADR-0002 (tiered MC/DC) and ADR-0005 (source-of-truth), our own hardware-facing code migrates here behind a HAL seam and is hardened. "100% MC/DC on 100% of drivers" is infeasible (~97% of kernel-driver LOC is vendor blobs; AIC8800 alone is 88.5K lines); the realistic, honest target is tiered.

Tier 1: 100% MC/DC

Self-contained logic with a clean seam, measured to 100% MC/DC (gcc-14 -fcondition-coverage) by the CI mcdc job (make -C drivers/*/test check):

Driver Seam MC/DC
relays/ relay_io vtable (sysfs backend + in-memory fake) 50/50 conditions, 100%
freshness/ produce/render callbacks (the "no stale numbers" guard) 66/66 conditions, 100%

Adding a Tier-1 driver: copy <name>.{c,h} here, put the hardware/OS calls behind a small injectable seam, then mirror relays/test/ (a fake backend for the logic branches + a real backend over a scratch tree for the plumbing). Reuse the shared gate: the Makefile calls bash ../../enforce-mcdc.sh <gcov.log> build/<name>.c.gcov build/test.rc (it derives the driver name from the .gcov file, so there is no per-driver copy to keep in sync). The CI mcdc job picks up any drivers/*/test/Makefile automatically.

Tier 2: Fault Injection

Drivers too large or too vendor/UI-coupled for literal MC/DC get fault-injection, branch coverage, and benchmarks against the simulator instead. Their hardware side is already modelled and tested here in ../sim/:

Driver Serious-testing status SDK model
modbus_engine.c (RS485 master) 8 pty scenarios + 3 wire/daemon checks (11 total) + fault-injection (flare-edge tools/modbus-sim/, green) sim::modbus RTU slave (11 tests, silent-drop/forced-NAK faults) + modbus_read_holding benchmark
warden_rga.c (RGA offload) offload-dispatch + CPU-fallback logic sim::rga recording improcess fake (programmable IM_STATUS) + rga_improcess benchmark
HPMCU supervisor (hpmcu.rs) arm/beat/fire + boot-grace safety property sim::hpmcu (7 tests) + hpmcu_tick benchmark

Why the Tier-2 source isn't vendored here yet: modbus_engine.c and warden_rga.c pull in shared UI headers (platform.h, settings.h, lv_*) and librga. Copying those in would duplicate exactly the shared surface the flare-edge↔SDK unification (ADR-0003/0005, a separate maintainer-gated step) is meant to resolve cleanly. So the Tier-2 models (the hardware ends) live here now; the Tier-2 driver sources migrate in with the unification, at which point their existing flare-edge harnesses point at this repo.