NoahandClaude Opus 5
9ff60d60db
dwc3_otg_host_init() carries the comment "should be called before Host controller driver is started". It rewrites OCTL/OCFG, touches GUSB2PHYCFG and re-asserts port power (OCTL.PrtPwrCtl). dwc3_otg_irq() sets otg_restart_host ONLY when current_otg_role is already DWC3_OTG_ROLE_HOST. The threaded handler then calls dwc3_otg_host_init() unconditionally, so that path always ran against a live, running host -- the exact condition the comment forbids. Re-asserting port power under a running xHCI corrupts an in-flight command. Observed on the RV1106 86-panel as the controller failing to answer a Stop Endpoint command, after which xhci-hcd declares it dead and tears the bus down. An r8152 USB NIC stalls a transfer and the controller died 8 times out of 8 between 452s and 587s. Compiling the OTG path out entirely (dr_mode=host) survived 1810s with zero deaths, which localised it here. On this board the event is always spurious: the dwc3 node deliberately carries no extcon, because wiring it pins the role to peripheral on D1-modded panels, and CONIDSTS reads 0 -- so the role cannot legitimately change while host is current. Skip the re-init in that case and log it at debug level. This does not remove the restart capability. dwc3_set_mode() still runs immediately below, and if the role has genuinely changed dwc3_otg_update() performs a proper dwc3_host_exit() before re-initialising. The only behaviour removed is poking a running controller, which was never legitimate. Refs flare-edge#160 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MVGTC78dgCGfRANNKjoPea
The Kernel Patch Series
The delta that forward-ports the vendor Rockchip 5.10.160 RV1106 support onto a
pristine upstream linux-6.18.46, as a reviewable, subsystem-split series. Every
patch applies cleanly onto pristine 6.18.46 (git apply --check), and the whole set
reproduces the 223-file / ~136K-line delta that boots and is hardware-verified on
warden-c8a3 (see ../kernel/rv1106-enablement/).
Build it with ../build/build-kernel.sh (fetch pristine -> apply these -> configure
with ../build/warden_defconfig -> zImage + rv1106-warden.dtb).
The Series
| Patch | Scope |
|---|---|
05-build-wiring.patch |
top-level drivers/{Kconfig,Makefile} (wire in rknpu) |
10-clk-rv1106.patch |
CRU clock driver (clk-rv1106.c, reuses rv1126 data) |
15-pinctrl.patch |
pinctrl-rockchip RV1106 iomux |
20-arch-dts-bindings.patch |
arch/arm DTs (rv1106.dtsi, rv1106-warden.dts, pinctrl), mach, configs, include/dt-bindings |
25-usb-phy.patch |
inno-usb2 phy |
30-drm-vop-panel-rgb.patch |
VOP (rgb_dclk_pol=0 + WIN1 scanout), panel-simple bus-format, rockchip_rgb |
35-mailbox-hpmcu.patch |
rockchip-mailbox (rv1106 num_chans=1) |
40-pvtm-soc.patch |
PVTM (core+pmu) + include/soc/rockchip/pvtm.h |
45-npu-rknpu.patch |
open GPL rknpu 0.9.2 driver + rknpu_ioctl.h uapi |
50-rga.patch |
RGA 2D (rga3) + drivers/video wiring |
60-wifi-aic8800.patch |
out-of-tree AIC8800 wifi/BT (the 88.5K-line vendor blob) |
70-audio-codec.patch |
rv1106_codec + I2S wiring |
80-misc-thermal-rtc-adc.patch |
tsadc, rtc-rockchip, saradc, trng, otp, gmac, goodix touch |
License
Everything in this directory is a derivative work of the Linux kernel and of GPL-2.0 vendor kernel code: GPL-2.0-only (or the per-file SPDX identifier where one is present), the same license the whole repository carries.
Provenance & regeneration
Baseline: linux-6.18.46 from kernel.org (build/linux-6.18.46.tar.xz.sha256
pins the tarball). The series was generated by overlaying the hardware-verified
source tree onto pristine (build artifacts excluded) and splitting git diff by
subsystem. Licensing/origin of each block is tracked in
../kernel/rv1106-enablement/PROVENANCE.md.
Whitespace: 60-wifi-aic8800.patch carries the vendor blob's trailing-whitespace
verbatim; git apply --whitespace=nowarn (the build wrapper) accepts it. Do not
re-flow vendor code; it must stay diffable against future vendor drops.