fix(gui): install feedback, local .afw picker, scan icons, report wrap #40

Open
noah wants to merge 0 commits from fix/gui-install-and-scan-1113 into main
Owner

Fixes the three bench bug reports filed from the toolkit plus the local-file install request. Built and unit-tested here (111 passing, 2 new regression tests); the GUI click paths and the S17 install need bench confirmation before the issues are closed.

#38 install gave no indicator / did not work

The activity log in #38 shows no install-start line between the scan and the report, so the install never reached the worker -- it aborted at a silent/subtle early return. Now every abort reason (missing FLASH keyword, no release/asset for the board, no target selected) raises the visible error indicator and keeps the dialog open, the start is logged and shown, and crucially the real per-board failure detail is surfaced and logged instead of a bare "1 failed".

Install source (your request): local .afw OR Gitea release, one window

The install dialog gains a "Browse local .afw..." button beside the release picker. A chosen file takes precedence. start_install now takes an AfwSource (Release downloaded as before, or Local used in place) -- the CLI local-file install, now in the GUI.

#39 false-green hashboard / PSU icons

A hashboard the firmware lists with no active flag and no working-chip count now reads grey (not detected), not green. The PSU bolt greens only on real delivery evidence (watts, PSU fan, or PSU output); is_mining counts only when actually hashing. Grounded against the real bench S17 at 10.255.1.111, which reports watts=0 with nothing attached. Regression tests added.

#37 bug-report text wrap

The report box word-wraps now (new text_ctrl_wrapped, no wxTE_DONTWRAP). Sub-window movability is left unchanged -- the dialog already carries a caption and resize border, so independent movement is window-manager behaviour, not an app setting.

References #37, #38, #39.

Generated with Claude Code

https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i

Fixes the three bench bug reports filed from the toolkit plus the local-file install request. Built and unit-tested here (111 passing, 2 new regression tests); the GUI click paths and the S17 install need bench confirmation before the issues are closed. ### #38 install gave no indicator / did not work The activity log in #38 shows no install-start line between the scan and the report, so the install never reached the worker -- it aborted at a silent/subtle early return. Now every abort reason (missing FLASH keyword, no release/asset for the board, no target selected) raises the visible error indicator and keeps the dialog open, the start is logged and shown, and crucially the real per-board failure detail is surfaced and logged instead of a bare "1 failed". ### Install source (your request): local .afw OR Gitea release, one window The install dialog gains a "Browse local .afw..." button beside the release picker. A chosen file takes precedence. `start_install` now takes an `AfwSource` (Release downloaded as before, or Local used in place) -- the CLI local-file install, now in the GUI. ### #39 false-green hashboard / PSU icons A hashboard the firmware lists with no active flag and no working-chip count now reads grey (not detected), not green. The PSU bolt greens only on real delivery evidence (watts, PSU fan, or PSU output); `is_mining` counts only when actually hashing. Grounded against the real bench S17 at 10.255.1.111, which reports watts=0 with nothing attached. Regression tests added. ### #37 bug-report text wrap The report box word-wraps now (new `text_ctrl_wrapped`, no `wxTE_DONTWRAP`). Sub-window movability is left unchanged -- the dialog already carries a caption and resize border, so independent movement is window-manager behaviour, not an app setting. References #37, #38, #39. Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 08:46:22 -07:00
fix(gui): install feedback, local .afw picker, scan icons, report wrap
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 10m54s
verify / verify-windows (pull_request) Skipped
aab9b63350
Addresses the bench bug reports filed from the toolkit (issues #37, #38, #39)
and the request for a local-file install source.

Install (issue #38): the install never reached the worker in the reported
case and aborts were only a status-bar line, so the operator saw nothing.
Abort reasons (missing FLASH keyword, no release/asset, no target) now raise
the visible error indicator and keep the dialog open; the actual per-board
failure detail is surfaced and logged instead of a bare count; a clear
"installing..." line and log entry mark the start.

Install source (requested): the install dialog gains a "Browse local .afw"
button beside the Gitea release picker, in the same window. A chosen file
takes precedence over the selected release. start_install takes an AfwSource
(Release or Local); a local file is used in place, a release is downloaded as
before. This brings the CLI's local-file install to the GUI.

Scan icons (issue #39): a hashboard the firmware lists with no active flag and
no working-chip count now reads grey (not detected) instead of green, and the
PSU bolt greens only on real delivery evidence (watts, PSU fan, or PSU output)
-- is_mining counts only when the miner is actually hashing. A stock S17
control board with no PSU or hashboards attached asserts a cgminer mining
status at zero watts, which previously showed green board and PSU icons.
Confirmed against the bench S17 at 10.255.1.111 (reports watts=0). Regression
tests added for both.

Bug report (issue #37): the report box word-wraps instead of running off the
edge (new wx text_ctrl_wrapped without wxTE_DONTWRAP). Sub-window movability
is window-manager behaviour (the dialog already has a caption and resize
border) and is not changed here.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 09:18:37 -07:00
feat(gui): drop typed-FLASH step; raise report-relay rate limit
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 8m16s
verify / verify-windows (pull_request) Skipped
f9cd12b374
Issue #41: installing alkane OS and restoring to stock no longer require
typing FLASH. The dialog, the board list and the Install/Restore button are
the confirmation; the destructive-action warning stays visible. Removes the
now-unused confirm inputs from the install and uninstall dialogs.

Report relay: raise RATE_PER_IP 5 -> 100 and RATE_GLOBAL 60 -> 300 so bench
testing can file more reports without hitting the hourly cap. Applied live on
the Gitea host and recorded here.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 09:56:07 -07:00
feat(gui): post-install verify, flash-plan checklist; backend helpers
source / check (pull_request) Skipped
verify / verify (pull_request) Canceled after 2m0s
verify / verify-windows (pull_request) Canceled after 0s
fbf44889ea
Stock->alkane re-scan flicker: after a successful install the just-installed
boards are held in a "verifying alkane..." state and a stock re-scan row is
suppressed until the board answers as alkane, with a bounded give-up window.
Fixes the board re-scanning as stock before finally showing alkane.

Flash-plan checklist: picking a local .afw in the install dialog now detects
the flash tier and shows a [x]/[ ] checklist of what it overwrites (U-Boot /
Kernel / Userspace), read from the bundle manifest. Verified end-to-end under
a virtual display: a zynq-7010 .afw shows tier 2, U-Boot preserved, kernel and
userspace written.

Backend helpers (alkane-artifacts, additive, unit-tested):
- AfwManifest::flash_plan() -> FlashPlan { tier, writes_uboot, writes_kernel,
  writes_userspace }.
- ReleaseSource::for_repo(owner, repo) and ReleaseInfo::compatible_boards /
  is_compatible_with, for the upcoming any-repo picker with board-compat
  detection.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 09:59:14 -07:00
feat(gui): install picker reads any repo with board-compat filtering
verify / verify-windows (pull_request) Canceled after 0s
source / check (pull_request) Skipped
verify / verify (pull_request) Canceled after 1m5s
7d5f250254
The install dialog gains a "Release repo (owner/repo)" field (default
blueflare/alkane-os) and a Reload button. Releases are scanned from the chosen
repo via ReleaseSource::for_repo and filtered to those with an .afw compatible
with the target board (ReleaseInfo::is_compatible_with). Verified under a
virtual display: the picker populates with the alkane-os release unauthenticated
now that the repo is public, and the repo field + Reload render.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 10:01:26 -07:00
feat(gui): progress bar in the Health cell during install/restore (#42)
source / check (pull_request) Skipped
verify / verify-windows (pull_request) Canceled after 0s
verify / verify (pull_request) Canceled after 4m10s
7e0174fda1
While a board installs or restores, its Health cell shows a phase-based ASCII
progress bar ("installing [#######---] 70%") instead of a static "installing".
Phases map to indicative, monotonic percents (acquire < verify < write). Adds
unit tests for the bar and the phase->percent mapping.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 10:06:59 -07:00
feat(gui): live activity-log view toggled from the toolbar
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 7m4s
verify / verify-windows (pull_request) Skipped
4f59233064
A "Log" toolbar button replaces the fleet table with a live view of the
toolkit activity log (what it is currently doing); the button flips to "Table"
to switch back. The view tails the log, appending new lines and staying
scrolled to the newest entry. Verified under a virtual display.

Placed in the toolbar (top-right) rather than the status bar: the native wx
status bar that holds the zoom slider cannot host a wx button, and the content
sizer has no insert, so a true bottom-right button needs extra plumbing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 10:22:02 -07:00
fix(gui): address code-review findings on the install/scan changes
verify / verify (pull_request) Failing after 5m53s
verify / verify-windows (pull_request) Skipped
source / check (pull_request) Skipped
7cd26aff56
- #1 Update must not rewrite the bootloader: start_install refuses a tier-3
  (bootloader-writing) .afw when the dialog is an in-place Update, enforcing the
  "BOOT.bin is never written" guarantee.
- #2 post-install verify could stick forever when auto-scan is off: tick() now
  re-probes awaiting boards on a fixed 10 s cadence until they answer as alkane
  or the give-up window expires.
- #3 board-health no longer greys a genuinely-mining miner whose backend omits
  per-board active/working_chips: (None,None) reads green when the miner is
  hashing, grey only when idle (the bare S17 case).
- #5 install docs/comments no longer describe the removed typed-FLASH step.
- #6 the flash-plan checklist verifies against the install target board, so a
  file for another board surfaces as an error instead of a misleading plan.
- #7 install board is taken from the selected row's board_family, not a fixed
  default (correct once more boards are supported).
- #4 (verify on the UI thread) accepted: .afw bundles are ~7 MB, so the manifest
  read is a sub-100 ms hash, not a user-visible freeze.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 11:02:41 -07:00
build(wx-rs): capture the word-wrap text-ctrl edit into the patch queue
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 8m11s
verify / verify-windows (pull_request) Skipped
69dcedbd9c
The #37 wrap fix edited the vendored wx-rs tree (wxbr_text_ctrl_wrap in the C++
bridge + text_ctrl_wrapped in widgets.rs) but not the patch queue, so the
`wx_rs_patches.py check` CI gate failed. Capture the delta as patch 0012 so the
queue reproduces the patched tree again.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 11:15:42 -07:00
style(gui): rustfmt + clippy fixes for the review changes
source / check (pull_request) Skipped
verify / verify (pull_request) Canceled after 44m33s
verify / verify-windows (pull_request) Canceled after 0s
25047a603a
Apply cargo fmt to the edited gui sources and switch a board_status membership
check from iter().any() to contains() so `cargo fmt --check` and
`clippy -D warnings` (the verify CI gates) pass.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 12:01:39 -07:00
ci(verify): drop verify-windows from the PR gate (Windows builds at release)
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 13m56s
dd3cff19cb
The Windows mingw+Wine cross-build roughly doubled PR wall-clock. Move it off
the PR gate: PRs now verify Linux (clippy, build, tests, self-test) fast, and
the Windows build is still produced and shipped by the main release run
(build-test-release / windows-native), so a Windows-only regression surfaces on
the merge to main.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 3 commits 2026-11-13 12:53:31 -07:00
A from-stock install now leaves a complete genuine-stock backup on the
board (stock device tree, kernel and ramdisk) in the reserved NAND region
after the alkane MAC area, clear of the stock configs UBI and all alkane
boot slots.

Add network-only StockMethod calls to check for that backup and restore
the board to genuine stock from it, with public wrappers and interface
tests. BOOT.bin is preserved.

Verified: cargo build -p alkane-flash; cargo test -p alkane-flash
(74 passed, 1 ignored).
feat(gui): two-choice restore, dialogs-during-scan, creds-from-settings
source / check (pull_request) Skipped
verify / verify (pull_request) Canceled after 12m59s
6e785275da
Restore-to-stock dialog overhaul (issues #46, #47, #48, #51): a two-source
restore -- the board's on-board stock backup (checkbox, auto-detected via the
merged alkane-flash onboard_stock_backup_present and greyed out with
set_enabled when absent) or a Bitmain stock firmware file picked with a Browse
button (OTA .tar.gz or SD .zip, any X17-series model). The alkane root login
comes from Settings (no per-dialog password field); on-board restore uses the
new stock_ops::start_restore_onboard over DSH's restore_from_onboard_backup.

Install dialog: password field removed too (#46); the login comes from Settings.

Dialogs during scan (#43): install/uninstall dialogs open and can be prepared
while a scan runs (new flash_busy gate); the scan is stopped only when the
operation actually starts (stop_scan_for_op) so the two never touch a board at
once.

Bug report (#50): the always-present "Open issue" button is gone; filing turns
it into a clickable "View issue #N" link.

wx-rs: add set_enabled (grey out a control); captured as patch 0013. Merges
DSH's alkane-flash on-board backup/restore method (sealed in stock_method.rs).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
noah added 1 commit 2026-11-13 13:08:30 -07:00
fix(gui): per-target credentials for install and restore (#46, #51)
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 31m29s
d2d4c085ae
"Install failed due to credentials" was the #46 change pulling one generic
saved SSH login for both directions. Install targets a stock board and restore
targets an alkane board, which need different logins. Add the alkane
control-board login to the shipped defaults ("Alkane" root/alkane) and a
`cred_for(firmware)` helper (saved per-firmware override, else shipped default).

Install now uses the selected stock board's firmware login (e.g. AntMiner
root/root); restore and the on-board-backup probe use the alkane login
(root/alkane). No password field; both overridable per-firmware in Settings.
Confirmed on the bench S17 at 10.255.1.111: its alkane login is root/alkane.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B1W6qKwKxq3oUPDKWicM6i
Some required checks failed
source / check (pull_request) Skipped
verify / verify (pull_request) Failing after 31m29s
Required
Details
This branch is already included in the target branch. There is nothing to merge.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin fix/gui-install-and-scan-1113:fix/gui-install-and-scan-1113
git checkout fix/gui-install-and-scan-1113
Sign in to join this conversation.