BFE EngineeringandClaude Opus 4.8
4ee4dfcf88
First recursive code-review-harness pass over the authored SDK code (sim/,
config-lint, flowgen, drivers/{relays,freshness}, build/, ci.yml). Four parallel
dimension reviewers; all findings at every severity corrected per workspace rule.
Correctness / reliability:
- freshness.c min_budget_ms: use a `seen` flag, not `best==0`, as the empty
sentinel — a zero-tolerance (max_stale_ms==0) binding was silently widened to a
looser neighbour's budget. Regression test added; still 66/66 MC/DC.
- config-lint parse_reserved_ranges: match `reg` as a whole property token (ident
boundary before, `=` after) so `reg-names` / a `region-*` label no longer
mis-parses into a bogus reserved range.
- config-lint loader check: fail closed — flag any loader with a LOAD_ADDR that is
not a known-safe boot component, instead of only known MCU names, so a future
coprocessor ("Rtos"/"Bl32") can't slip past the 0x40000-brick gate.
- build-kernel.sh: sha256 verification is now mandatory (refuse to build if the pin
is missing) and the mktemp scratch tree is removed on exit (trap), while a
caller-provided WORK is left intact for CI artifact upload.
Test quality:
- freshness: added the age==max_stale boundary case and a clock-wraparound
(now < last_ok) fail-safe-to-UNKNOWN test.
- relays: unsetenv(WARDEN_GPIO_ROOT) at main() so the NULL-env arm is hermetic.
Security / CI:
- ci.yml: top-level `permissions: contents: read` (badges overrides to write);
pin taiki-e/install-action to commit SHA (v2.86.7).
Maintainability / docs:
- drivers/enforce-mcdc.sh: one shared, name-derived gate replaces the two
copy-pasted per-driver scripts; Makefiles call ../../enforce-mcdc.sh.
- docs/architecture.md: §3/§4/§6/§7 rewritten to match reality — NPU/RGA models,
config-lint, and the relays+freshness MC/DC harnesses are done; kernel §6 now
reflects the 5.10->6.18.46 forward-port (ADR-0001), not the superseded plan44/6.6.
- README: status blurb + layout table corrected (kernel/, .github/; stale ci/ and
patches/ descriptions fixed). hpmcu "8 tests" -> 7 in docs.
- freshness.{c,h}: ADR reference points at flare-edge ADR-0004 (warden-sdk's
ADR-0004 is the CI runner — number collision).
- normalize rustfmt drift across sim/ + config-lint.
All green: sim 37 tests, config-lint 8 tests, both drivers 100% MC/DC (relays
40/40, freshness 66/66), clippy clean under -D warnings, gitleaks clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017wB8KB3MMQztRDXCMCkPrf
97 lines
3.6 KiB
Bash
Executable File
97 lines
3.6 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Hermetic-ish kernel build for the WardenOS 86-Panel (RV1106).
|
|
#
|
|
# fetch pristine linux-6.18.46 -> apply patches/ in order -> configure with
|
|
# build/warden_defconfig -> build zImage + rv1106-warden.dtb.
|
|
#
|
|
# The pristine tree is the ONLY external input; the delta is patches/. A build
|
|
# from a clean checkout + a verified tarball is reproducible.
|
|
#
|
|
# Env:
|
|
# KERNEL_TARBALL path to a local linux-6.18.46.tar.xz (skips the download)
|
|
# SDK_TC dir holding the arm-rockchip830 uclibc cross toolchain bin/
|
|
# WORK build scratch dir (default: a mktemp under $TMPDIR)
|
|
# JOBS parallel make jobs (default: nproc)
|
|
#
|
|
# Requires: `python` (not python3) on PATH — the SDK quirk; the CI runner provides
|
|
# a project-local venv. Builds are SERIAL on the shared SDK box — never run two.
|
|
set -euo pipefail
|
|
|
|
KVER=6.18.46
|
|
HERE="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" # build/
|
|
REPO="$(cd "$HERE/.." && pwd)"
|
|
PATCHES="$REPO/patches"
|
|
SHA_FILE="$HERE/linux-$KVER.tar.xz.sha256"
|
|
JOBS="${JOBS:-$(nproc)}"
|
|
URL="https://cdn.kernel.org/pub/linux/kernel/v6.x/linux-$KVER.tar.xz"
|
|
|
|
# A caller-provided WORK (e.g. CI's ${{ github.workspace }}/kbuild-out, from which
|
|
# artifacts are uploaded) is left intact; a scratch dir we mktemp'd here is our own
|
|
# (>1GB of extracted source + build output) and is removed on exit so repeated runs
|
|
# on the shared SDK box don't fill the disk.
|
|
if [ -n "${WORK:-}" ]; then
|
|
WORK_OWNED=0
|
|
else
|
|
WORK="$(mktemp -d "${TMPDIR:-/tmp}/warden-kbuild.XXXXXX")"
|
|
WORK_OWNED=1
|
|
fi
|
|
trap '[ "${WORK_OWNED:-0}" = 1 ] && rm -rf "$WORK"' EXIT
|
|
|
|
log() { printf '\033[36m== %s\033[0m\n' "$*"; }
|
|
|
|
command -v python >/dev/null || { echo "need 'python' (not python3) on PATH — SDK quirk" >&2; exit 1; }
|
|
|
|
# 1. obtain + verify the pristine tarball
|
|
mkdir -p "$WORK"
|
|
TB="${KERNEL_TARBALL:-$WORK/linux-$KVER.tar.xz}"
|
|
if [ ! -f "$TB" ]; then
|
|
log "downloading $URL"
|
|
curl -fSL "$URL" -o "$TB"
|
|
fi
|
|
# Fail closed: a missing pin (e.g. forgotten on a KVER bump) or a KERNEL_TARBALL
|
|
# pointed at an arbitrary file must refuse to build, never silently skip the check
|
|
# — the pristine tarball is the ONLY external input and integrity is the whole point.
|
|
[ -f "$SHA_FILE" ] || {
|
|
echo "FATAL: no pinned sha256 for linux-$KVER (expected $SHA_FILE) — refusing to build from an unverified tarball" >&2
|
|
exit 1
|
|
}
|
|
want="$(cat "$SHA_FILE")"
|
|
got="$(sha256sum "$TB" | awk '{print $1}')"
|
|
[ "$want" = "$got" ] || { echo "tarball sha256 mismatch: want $want got $got" >&2; exit 1; }
|
|
log "tarball sha256 verified"
|
|
|
|
# 2. extract pristine
|
|
SRC="$WORK/linux-$KVER"
|
|
rm -rf "$SRC"
|
|
log "extracting pristine"
|
|
tar -C "$WORK" -xf "$TB"
|
|
|
|
# 3. apply the patch series in order
|
|
log "applying patch series"
|
|
for p in "$PATCHES"/*.patch; do
|
|
git -C "$SRC" apply --whitespace=nowarn "$p" 2>/dev/null \
|
|
|| patch -d "$SRC" -p1 --no-backup-if-mismatch < "$p"
|
|
echo " applied $(basename "$p")"
|
|
done
|
|
|
|
# 4. configure
|
|
log "configuring (warden_defconfig)"
|
|
cp "$HERE/warden_defconfig" "$SRC/.config"
|
|
export ARCH=arm CROSS_COMPILE=arm-rockchip830-linux-uclibcgnueabihf-
|
|
if [ -n "${SDK_TC:-}" ]; then export PATH="$SDK_TC:$PATH"; fi
|
|
command -v "${CROSS_COMPILE}gcc" >/dev/null \
|
|
|| { echo "cross toolchain ${CROSS_COMPILE}gcc not on PATH (set SDK_TC)" >&2; exit 1; }
|
|
make -C "$SRC" ARCH=arm CROSS_COMPILE="$CROSS_COMPILE" olddefconfig >/dev/null
|
|
|
|
# 5. build zImage + the board dtb
|
|
log "building zImage + rv1106-warden.dtb (-j$JOBS)"
|
|
make -C "$SRC" ARCH=arm CROSS_COMPILE="$CROSS_COMPILE" -j"$JOBS" \
|
|
zImage rockchip/rv1106-warden.dtb
|
|
|
|
Z="$SRC/arch/arm/boot/zImage"
|
|
D="$SRC/arch/arm/boot/dts/rockchip/rv1106-warden.dtb"
|
|
log "build OK"
|
|
ls -la "$Z" "$D"
|
|
echo "zImage: $Z"
|
|
echo "dtb: $D"
|